dfp: allowing the dfp cluster to do dns lookups #38237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
async-dns
branch
3 times, most recently
from
3e66464 to
ce1d3c8
Compare
Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
requested review from
wbpcode,
zuercher,
nezdolik and
mattklein123
as code owners
|
Coverage failure is real. I think I addressed one issue in the latest push but I want to add an e2e test of request cancelation during DFP lookup. I think the code is ready for a pass regardless if you're game |
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
| HostConstSharedPtr host; | ||
| std::string details; |
There was a problem hiding this comment.
Perhaps a comment on what details represents.
envoy/upstream/load_balancer.h
Outdated
| */ | ||
| virtual void onAsyncHostSelection(HostConstSharedPtr&& host) PURE; | ||
| virtual void onAsyncHostSelection(HostConstSharedPtr&& host, std::string details) PURE; |
There was a problem hiding this comment.
Should this perhaps be std::string&& to avoid a copy?
| // LoadDnsCacheEntryHandlePtr ensures that no callback will occur, at which | ||
| // point it is safe to delete the DFPHostSelectionHandle. | ||
| struct DFPHostSelectionHandle | ||
| : public Upstream::AsyncHostSelectionHandle, |
There was a problem hiding this comment.
nit: AsyncHostSelectionHandle is a class, so anything which extends it should also be a class I think.
Signed-off-by: Alyssa Wilk <[email protected]>
RyanTheOptimist
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows bypassing the DFP for most DFP use. It does not yet support the use case use_subcluster_config at which point DFP is still required.
Risk Level: meidum
Testing: MORE NEEDED
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] envoy.reloadable_features.dfp_cluster_resolves_hosts